-
Notifications
You must be signed in to change notification settings - Fork 0
Universal XMP Tags #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mypy.ini
Outdated
| explicit_package_bases = True | ||
| scripts_are_modules = True | ||
| strict = True | ||
| warn_unused_ignores = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete the unused ignore comment instead of setting this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elliott-imhoff Not sure whats up with this one, its passing in my local pre-commit environment but failing in the lint test: Fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the doc string on the XMPTags class to say either empty strings or common defaults. If the tag doesn't exist, a KeyError will be thrown. Other than that, this looks good!
elliott-imhoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Universal XMP Tags
What?
Why?
PR Checklist
Breaking Changes