fix(slack): add channels:join scope and fix zero-value last_sync bug#53
Merged
Conversation
Two fixes for Slack integration: - Add channels:join OAuth scope so bot auto-joins public channels on install - Fix fresh-install sync: when last_sync is unset (0), omit the oldest parameter instead of passing "0.000000" which Slack rejects with invalid_ts_oldest, blocking all message sync - Add SlackClient test coverage with mock HTTP client (requires HTTPDoer interface on SlackClient for testability) Closes: real Slack integration testing
Fix alignment in table-driven test structs and map literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
channels:joinOAuth scope so bot auto-joins public channels after install (no manual/inviteneeded)last_syncis unset (0), omit theoldestparameter instead of passing"0.000000"which Slack rejects withinvalid_ts_oldestSlackClientunit tests (mock HTTP client) — requiresHTTPDoerinterface onSlackClientChanges
services/slack.goHTTPDoerinterface for testabilityservices/sync.gooldestparam: only pass whenlastSync > 0handlers/integrations.gochannels:jointo OAuth scope stringservices/slack_client_test.goTest plan
go test ./...passes