docs(readme): drop outdated TODO — sentrix-proto crate in use#34
Merged
Conversation
crates/chain/proto/ vendored .proto was retired when sentrix-proto 0.1.1 landed on crates.io (sentrix-labs/sentrix#667 + #670). Cargo.toml already pins sentrix-proto = "0.1.1"; the README directory tree still mentioned the vendored path with a TODO. - README.md:38 — drop "vendored — TODO swap for sentrix-proto crate from crates.io"
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates README.md to clarify that Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
`crates/chain/proto/` vendored `.proto` was retired when `sentrix-proto 0.1.1` landed on crates.io (sentrix-labs/sentrix#667 + #670). `Cargo.toml` already pins `sentrix-proto = "0.1.1"`; the README directory tree still mentioned the vendored path with a TODO.
What
Test plan
Summary by CodeRabbit