Skip to content

chore: scrub internal-file ref from generated gRPC client headers#23

Merged
github-actions[bot] merged 1 commit into
mainfrom
chore/scrub-internal-refs
May 13, 2026
Merged

chore: scrub internal-file ref from generated gRPC client headers#23
github-actions[bot] merged 1 commit into
mainfrom
chore/scrub-internal-refs

Conversation

@satyakwok
Copy link
Copy Markdown
Member

@satyakwok satyakwok commented May 13, 2026

Both src/grpc-web/sentrix.ts and src/grpc-web/sentrix.client.ts had header blocks referencing founder-private/audits/...-grpc-service-proto-draft.md.

The upstream .proto in sentrix-labs/sentrix already carries the neutral phrasing 'internal Sentrix Labs gRPC service-proto draft (2026-05-05)'; the regenerated .ts here didn't pick up that change. This PR updates by hand to match — next regeneration via protobuf-ts will produce the same text.

Summary by CodeRabbit

  • Chores
    • Updated internal documentation references in service files. No functional changes to user-facing behavior.

Review Change Stack

Both grpc-web/*.ts header blocks referenced
'founder-private/audits/...-grpc-service-proto-draft.md'. The
upstream .proto in sentrix-labs/sentrix already carries the neutral
phrasing 'internal Sentrix Labs gRPC service-proto draft (2026-05-05)';
the regenerated .ts here didn't pick up that change. Updated by hand
to match — next regeneration via protobuf-ts will produce the same
text.
@github-actions github-actions Bot enabled auto-merge (squash) May 13, 2026 07:53
@github-actions github-actions Bot merged commit 45de27f into main May 13, 2026
4 of 5 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7e3fc915-857d-4cd9-8e54-ec4e355016a7

📥 Commits

Reviewing files that changed from the base of the PR and between 668c342 and 94f8aa8.

📒 Files selected for processing (2)
  • src/grpc-web/sentrix.client.ts
  • src/grpc-web/sentrix.ts

📝 Walkthrough

Walkthrough

The PR updates internal design documentation references in two gRPC client files located in src/grpc-web/. Both changes replace existing design-doc comment references with a pointer to the internal Sentrix Labs gRPC service-proto draft dated 2026-05-05. No code logic, type definitions, exports, or runtime behavior changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides context for the changes but does not follow the required template structure with Summary, Test plan, and Related sections. Reorganize the description to match the template: add a Summary section (1-3 sentences), include a Test plan section with a checklist, and add a Related section with issue/PR links.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: scrubbing internal file references from generated gRPC client headers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/scrub-internal-refs

Comment @coderabbitai help to get the list of available commands and usage tips.

github-actions Bot pushed a commit that referenced this pull request May 13, 2026
The grpc-web TypeScript output here was already neutralized via #23,
but the upstream .proto in src/grpc-proto/ still carried the old line.
Patched to match the canonical phrasing.

Co-authored-by: satyakwok <satyakwok@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant