chore: scrub internal-file ref from generated gRPC client headers#23
Merged
Conversation
Both grpc-web/*.ts header blocks referenced 'founder-private/audits/...-grpc-service-proto-draft.md'. The upstream .proto in sentrix-labs/sentrix already carries the neutral phrasing 'internal Sentrix Labs gRPC service-proto draft (2026-05-05)'; the regenerated .ts here didn't pick up that change. Updated by hand to match — next regeneration via protobuf-ts will produce the same text.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates internal design documentation references in two gRPC client files located in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
github-actions Bot
pushed a commit
that referenced
this pull request
May 13, 2026
The grpc-web TypeScript output here was already neutralized via #23, but the upstream .proto in src/grpc-proto/ still carried the old line. Patched to match the canonical phrasing. Co-authored-by: satyakwok <satyakwok@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both src/grpc-web/sentrix.ts and src/grpc-web/sentrix.client.ts had header blocks referencing founder-private/audits/...-grpc-service-proto-draft.md.
The upstream .proto in sentrix-labs/sentrix already carries the neutral phrasing 'internal Sentrix Labs gRPC service-proto draft (2026-05-05)'; the regenerated .ts here didn't pick up that change. This PR updates by hand to match — next regeneration via protobuf-ts will produce the same text.
Summary by CodeRabbit