docs(readme): update Architecture tree post-sentrix-proto migration#33
Conversation
The proto schema was extracted into a standalone `sentrix-proto` crate on crates.io (chain repo PR #667) and this app migrated to consume it in PR #32 — local `proto/` + `build.rs` + tonic codegen are gone. The Architecture diagram still showed: proto/sentrix.proto → build.rs / tonic-build → src/grpc/pb Updated to reflect the current path: sentrix-proto crate → re-exported as `pb` in src/grpc/mod.rs Includes the wasm-specific `default-features = false` note since the transport feature gate is the whole reason that migration shipped.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates the README architecture diagram to reflect a change in how protocol buffer definitions are sourced. Proto definitions now come from an external Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
10 of N in the all-READMEs polish sweep. Architecture diagram still showed
proto/sentrix.proto → build.rs / tonic-build → src/grpc/pbbut PR #32 dropped local proto + build.rs and migrated to the publishedsentrix-protocrate from crates.io. Updated diagram + added the wasm-specificdefault-features = falsenote.Summary by CodeRabbit