fix(android): proper release signing + R8 minify (audit H2 + H3)#13
Merged
github-actions[bot] merged 2 commits intomainfrom May 7, 2026
Merged
fix(android): proper release signing + R8 minify (audit H2 + H3)#13github-actions[bot] merged 2 commits intomainfrom
github-actions[bot] merged 2 commits intomainfrom
Conversation
Audit findings 2026-05-07: H2 (HIGH): release builds were signed with the debug keystore. Anyone could resign the published APK and impersonate Solux. Now reads release signing config from local key.properties (gitignored) OR CI env vars (SOLUX_KEYSTORE_PATH/_PASSWORD/_KEY_ALIAS/_KEY_PASSWORD). Build fails fast with a clear error if neither is provided. H3 (HIGH): release builds had no minify / no R8. When the crypto layer lands, an unminified binary makes keystore logic + signing flow trivially readable. Enabling R8 + resource shrinking now (pre-crypto) so the discipline is in place before sensitive code arrives. Stub proguard-rules.pro added with Flutter keeps. .gitignore: never commit key.properties / *.jks / *.keystore. Operator action items post-merge: 1. Generate a release keystore (one-time): keytool -genkey -v -keystore solux-release.jks -keyalg RSA -keysize 2048 -validity 10000 -alias solux 2. Add it to GH secrets (4 values: SOLUX_KEYSTORE_PATH, _PASSWORD, _KEY_ALIAS, _KEY_PASSWORD) 3. Update CI workflow to base64-decode keystore from secret + set env vars before flutter build apk 4. (separate work) Add release signing job to release pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two HIGH findings from 2026-05-07 audit:
H2 — release builds were signed with debug keystore (
signingConfig = signingConfigs.getByName("debug")). Anyone could resign + replace published APK. Now reads release signing fromkey.properties(local, gitignored) ORSOLUX_KEYSTORE_*env vars (CI). Fails fast if neither configured.H3 — release builds had no minify (
isMinifyEnabled = false). Pre-crypto layer lands, enable R8 + resource shrinking so discipline is in place when sensitive code arrives.Operator next steps post-merge
keytool -genkey -v -keystore solux-release.jks -keyalg RSA -keysize 2048 -validity 10000 -alias soluxflutter build apk