Connection with Web socket

[emmanuelbertho]

Hello,

I am trying to connect to a broker with web socket and I think there is an error in the connection method in SparkplugNodeBase.cs line 296.

I think in builder.WithWebSocketServer(this.Options.BrokerAddress, this.Options.WebSocketParameters); the first parameter shouldn't be just the broker address but {brokerAdress}:{port}.

I tested the modification and it works on my side.

Emmanuel

[SeppPenner]

I'm not 100 percent sure, this depends on how you want to reach your websocket, e.g. if there is a connection like mqtt.eclipseprojects.io:443/mqtt, this would not work. Maybe I can add something like this:

if (this.Options.BrokerPort is null)
{
    builder.WithWebSocketServer(this.Options.BrokerAddress, this.Options.WebSocketParameters);
}
else
{
    builder.WithWebSocketServer($"{this.Options.BrokerAddress}:{this.Options.BrokerPort}", this.Options.WebSocketParameters);
}

[SeppPenner]

I'm not 100 percent sure, this depends on how you want to reach your websocket, e.g. if there is a connection like mqtt.eclipseprojects.io:443/mqtt, this would not work. Maybe I can add something like this:

if (this.Options.BrokerPort is null)
{
    builder.WithWebSocketServer(this.Options.BrokerAddress, this.Options.WebSocketParameters);
}
else
{
    builder.WithWebSocketServer($"{this.Options.BrokerAddress}:{this.Options.BrokerPort}", this.Options.WebSocketParameters);
}

This doesn't work as I want to keep 1883 as default TCP port...

I have added a new hint here: https://github.com/SeppPenner/SparkplugNet/blob/master/HowToUse.md#connection-via-websocket-to-mqtt-server. Since I want to keep 1883 as default port for TCP (and I'm not sure how I should handle the WebSocket scenario with that precondition, my recommendation would be to specify the complete url (e.g. mqtt.eclipseprojects.io:443/mqtt or maybe test.something.com:443) as option for BrokerAddress.