Skip to content

Unified interface#21

Merged
SeppPenner merged 18 commits intoSeppPenner:masterfrom
BoBiene:unifiedInterface
Sep 18, 2022
Merged

Unified interface#21
SeppPenner merged 18 commits intoSeppPenner:masterfrom
BoBiene:unifiedInterface

Conversation

@BoBiene
Copy link
Copy Markdown
Contributor

@BoBiene BoBiene commented Aug 27, 2022 •
edited
Loading

based on #20

I tried to prevent any breaking changes

  • added IMetrics interface
  • added ISparkplugConnection
  • added SparkplugBaseOptions
  • added TLS options
  • added option to disable
    • AddSessionNumberToCommandMessages
    • AddSessionNumberToDataMessages
  • added Async Event-Pattern
  • added more events
    • Application
      • DeviceBirthReceived
      • DeviceDeathReceived
      • NodeBirthReceived
      • NodeDeathReceived
  • added SparkplugTopic & SparkplugMessageTopic class
  • use IEnumerable for Metrics instead of List in parameters
  • added KnownMetricStorage
    • possiblity for clients to change the behavior when the metric is not in the Known-Metric list

BoBiene added 5 commits August 24, 2022 18:51
@BoBiene
abstract base class
f826978 
- made Application & NodeBase abstract
- moved A & B specific code to child classes
- apply code format
@BoBiene
wip
5306587
@BoBiene
wip
d1c7e03
@BoBiene
Filter & Validate metrics in baseclass
d98b01a
@BoBiene
Added KnownMetricStorage
8b69368
@SeppPenner SeppPenner self-assigned this Aug 28, 2022
@SeppPenner SeppPenner added the enhancement New feature or request label Aug 28, 2022
@SeppPenner
Copy link
Copy Markdown
Owner

SeppPenner commented Aug 28, 2022

This will take a bit longer to verify, but seems to be a good idea.

@BoBiene
Copy link
Copy Markdown
Contributor Author

BoBiene commented Sep 1, 2022

I've found some issues and will fix them the next days.

@BoBiene BoBiene marked this pull request as draft September 1, 2022 08:13
@SeppPenner
Copy link
Copy Markdown
Owner

SeppPenner commented Sep 1, 2022

I've found some issues and will fix them the next days.

No problem, I haven't looked at it yet and will be on vacation for some days either ;)

@BoBiene BoBiene marked this pull request as ready for review September 8, 2022 11:50
@BoBiene
Copy link
Copy Markdown
Contributor Author

BoBiene commented Sep 8, 2022 •
edited
Loading

@SeppPenner so hopefully that is all. It will go through our QA department as part of our usage, so maybe some fixes will follow. But the general work is done from my side. I'm looking forward to your feedback.

@BoBiene
Copy link
Copy Markdown
Contributor Author

BoBiene commented Sep 15, 2022

@SeppPenner did you already find some time to look at this?

@SeppPenner
Copy link
Copy Markdown
Owner

SeppPenner commented Sep 18, 2022

@SeppPenner did you already find some time to look at this?

Not yet, but I will check it right now :)

@SeppPenner SeppPenner merged commit a4eea95 into SeppPenner:master Sep 18, 2022
@SeppPenner
Copy link
Copy Markdown
Owner

SeppPenner commented Sep 20, 2022

@all-contributors please add @BoBiene for code test

@allcontributors allcontributors Bot mentioned this pull request Sep 20, 2022
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors Bot commented Sep 20, 2022

@SeppPenner

I've put up a pull request to add @BoBiene! 🎉

@SeppPenner
Copy link
Copy Markdown
Owner

SeppPenner commented Sep 20, 2022

I have merged your pull request and checked it. Looks very good (I just adjusted some code style things mainly).

I still need to verify your question on Gitter (Where the events should occur-Node or application) and need to check the async events (and probably should run some tests with the new code) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SeppPenner SeppPenner

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BoBiene @SeppPenner