Skip to content

Device Storage#31

Merged
SeppPenner merged 4 commits intoSeppPenner:masterfrom
Patrick2607:device-storage
Nov 16, 2022
Merged

Device Storage#31
SeppPenner merged 4 commits intoSeppPenner:masterfrom
Patrick2607:device-storage

Conversation

@Patrick2607
Copy link
Copy Markdown
Contributor

@Patrick2607 Patrick2607 commented Nov 3, 2022

  • Changed KnownDevices to use MetricStorage instead of a List of Metrics
  • Refactored SparkplugNodeBase.PublishMessageForDevice
  • Fixed an assignment issue where the DeviceIdentifier would represent itself as the EdgeNodeIdentifier in the DeviceDataEventArgs

This should resolve #28

- Added Device MetricStorage instead of a List of Metrics
- Refactored PublishMessageForDevice
Patrick2607 and others added 3 commits November 3, 2022 19:58
Changed the Exception thrown when deviceMetricStorage is null
…itself as the EdgeNodeIdentifier in the DeviceDataEventArgs
@SeppPenner SeppPenner self-assigned this Nov 8, 2022
@SeppPenner
Copy link
Copy Markdown
Owner

I need to check this, but looks good from the first view.

@Patrick2607
Copy link
Copy Markdown
Contributor Author

I need to check this, but looks good from the first view.

Any update?

@SeppPenner SeppPenner merged commit e377265 into SeppPenner:master Nov 16, 2022
@SeppPenner
Copy link
Copy Markdown
Owner

Sorry for the delay. I have integrated your pull request and need to test it a bit more for now. An update should be available soon :)

@SeppPenner SeppPenner added the enhancement New feature or request label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug on publishing data for devices.

2 participants