finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type#249
Merged
SergeyPirogov merged 1 commit intoSergeyPirogov:masterfrom Oct 16, 2021
Conversation
|
Hello @aleksandr-kotlyar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-10-16 08:58:21 UTC |
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 88.14% 88.17% +0.02%
==========================================
Files 11 11
Lines 464 465 +1
Branches 53 52 -1
==========================================
+ Hits 409 410 +1
Misses 37 37
Partials 18 18
Continue to review full report at Codecov.
|
…version and OS type - Feature: finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type (Closes SergeyPirogov#243, SergeyPirogov#242) - Fix: Add rights to execute edgedriver binary on linux. - Test Coverage: More tests for EdgeDriver & testing on LINUX/MAC in CI. - delete requirements.txt
5fa1f03 to
9794a98
Compare
miguelius
pushed a commit
to miguelius/webdriver_manager
that referenced
this pull request
Oct 18, 2021
…version and OS type (SergeyPirogov#249) - Feature: finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type (Closes SergeyPirogov#243, SergeyPirogov#242) - Fix: Add rights to execute edgedriver binary on linux. - Test Coverage: More tests for EdgeDriver & testing on LINUX/MAC in CI. - delete requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.