Skip to content

ItemKey: Add ItemKey::Color #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Serial-ATA merged 1 commit into from
Jan 5, 2023
Merged

ItemKey: Add ItemKey::Color #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- **MP4**:
- The `InitialKey`, `ReplayGain*`, and "precise BPM" identifiers now have `ItemKey` mappings ([PR](https://github.com/Serial-ATA/lofty-rs/pull/93))
- `AtomIdent` now implements `TryFrom<ItemKey>` ([PR](https://github.com/Serial-ATA/lofty-rs/pull/96))
- Added support for the vendor-supplied XID in files from the Apple iTunes store as `AppleXID`.
- Added support for the vendor-supplied XID in files from the Apple iTunes store as `ItemKey::AppleXID`.
- **Vorbis Comments**:
- Additional mappings for the `Label`, `Remixer`, and `EncodedBy` `ItemKey` variants ([PR](https://github.com/Serial-ATA/lofty-rs/pull/94))
- **ID3v2**: A new `id3v2_compression_support` feature to optionally depend on `flate2` for decompressing frames
- **ItemKey**:
- New Variants: `AppleXID`, `Director`, `Color`

### Changed
- **MP4**: `AtomIdent` stores freeform identifiers as `Cow<str>` opposed to `String` ([PR](https://github.com/Serial-ATA/lofty-rs/pull/95))
Expand Down
5 changes: 5 additions & 0 deletions src/tag/item.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ gen_map!(
"REPLAYGAIN_TRACK_GAIN" => ReplayGainTrackGain,
"REPLAYGAIN_TRACK_PEAK" => ReplayGainTrackPeak,
"Genre" => Genre,
"Color" => Color,
"Mood" => Mood,
"Copyright" => CopyrightMessage,
"Comment" => Comment,
Expand Down Expand Up @@ -188,6 +189,7 @@ gen_map!(
"WPUB" => PublisherURL,
"TCON" => Genre,
"TKEY" => InitialKey,
"COLOR" => Color,
"TMOO" => Mood,
"TBPM" => BPM,
"TCOP" => CopyrightMessage,
Expand Down Expand Up @@ -245,6 +247,7 @@ gen_map!(
"\u{a9}enc" => EncodedBy,
"\u{a9}too" => EncoderSoftware,
"\u{a9}gen" => Genre,
"----:com.apple.iTunes:COLOR" => Color,
"----:com.apple.iTunes:MOOD" => Mood,
"----:com.apple.iTunes:BPM" | "tmpo" => BPM, // precise bpm (freeform atom) vs. integer bpm (fourcc atom) as fallback
"----:com.apple.iTunes:initialkey" => InitialKey,
Expand Down Expand Up @@ -338,6 +341,7 @@ gen_map!(
"REPLAYGAIN_TRACK_GAIN" => ReplayGainTrackGain,
"REPLAYGAIN_TRACK_PEAK" => ReplayGainTrackPeak,
"GENRE" => Genre,
"COLOR" => Color,
"MOOD" => Mood,
"BPM" => BPM,
"COPYRIGHT" => CopyrightMessage,
Expand Down Expand Up @@ -529,6 +533,7 @@ gen_item_keys!(
// Style
Genre,
InitialKey,
Color,
Mood,
BPM,

Expand Down