Skip to content

Add more IntoIterator implementations #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Serial-ATA merged 4 commits into from
Jan 14, 2023
Merged

Add more IntoIterator implementations #120

Serial-ATA merged 4 commits into from
Jan 14, 2023

Conversation

@uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Jan 11, 2023

For consistency.

@Serial-ATA
Copy link
Owner

Serial-ATA commented Jan 11, 2023

Could you add ones for VorbisComments and RIFFInfoList?

Serial-ATA
Serial-ATA reviewed Jan 12, 2023
View reviewed changes
@uklotzde
Copy link
Contributor Author

uklotzde commented Jan 12, 2023

Could you add ones for VorbisComments and RIFFInfoList?

This turns out to be much more tricky than I expected. I have even deliberately removed some IntoIterator implementations were the internal contents are split into items and pictures.

@Serial-ATA Serial-ATA merged commit 100b7e2 into Serial-ATA:main Jan 14, 2023
@uklotzde uklotzde deleted the into_iterator branch January 14, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Serial-ATA Serial-ATA Serial-ATA left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uklotzde @Serial-ATA