OGG: Properly handle large packets #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…written page size
Serial-ATA
force-pushed
the
ogg-corruption
branch
from
89c630a to
9a9d575
Compare
uklotzde
reviewed
Jan 18, 2023
Contributor
uklotzde
left a comment
uklotzde
left a comment
There was a problem hiding this comment.
Wouldn't it be possible to generate a huge JPG file during the test on the fly instead of storing such a large binary files in the repo?
Owner
Author
|
Good call. 🙂 |
Serial-ATA
force-pushed
the
ogg-corruption
branch
from
9a9d575 to
4a5734d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #130