Split and rejoin tags for read/modify/write round trips #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new trait
SplitAndRejoinTagwith methods that are needed for safely and efficiently implementing read/modify/write round trips when synchronizing metadata:fn split_tag(&mut self) -> Tag;fn rejoin_tag(&mut self);The central function from my code base that accomplishes the task demonstrates how they are supposed to be used:
Ideally the task would be implemented using a type-state-pattern that consumes its arguments to prevent mutating the remainder between split and rejoin. I am considering this alternative, stay tuned...Didn't turn out as helpful. I left a comment in the docs in case anyone has the same idea.