picture: add into_data()
#173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serial-ATA
requested changes
Mar 24, 2023
Owner
Serial-ATA
left a comment
Serial-ATA
left a comment
There was a problem hiding this comment.
Thanks! The reason I chose data() instead of as_bytes() is Picture represents more than just the image file. That's why there are as_{ape, apic, flac}_bytes() methods.
Contributor
Author
|
Ah, I see. Requested changes were made. |
Owner
|
Thanks! |
hinto-janai
added a commit
to hinto-janai/festival
that referenced
this pull request
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some functions that exposes the inner data.
Since the inner
CowisCow::Owned,into_owned()should be a cheap no-clone/no-allocation call.Also, most libraries seem use
bytes()oras_bytes()instead ofdata()but that'll break everyone's code, so, maybe not worth it.