probe: Add new default ParsingMode variant #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `BestAttempt` variant will be less eager to error than the previous default, `ParsingMode::Strict`. This comes with the consequence that the input may not be *entirely* correct.
uklotzde
reviewed
Jun 3, 2023
| /// | ||
| /// This mode will attempt to fill in any holes where possible in otherwise valid, spec-compliant input. | ||
| /// | ||
| /// NOTE: A readable input does *not* necessarily make it writeable. |
Contributor
There was a problem hiding this comment.
Concise disclaimer 👍 That's exactly what clients need to be prepared for.
This introduces 3 new possibilities: * Failure in `Strict` when encountering a mixed-encoding vendor string (previously continued) * Ignoring failed picture reading in `Relaxed` (previously errored) * Failure in `Strict` when an invalid key is encountered (previously skipped)
A UFID frame without an owner is invalid, and will fail in `ParsingMode::Strict`. In `ParsingMode::BestAttempt`, however, we will just replace it with an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
BestAttemptvariant will be less eager to error than the previous default,ParsingMode::Strict. This comes with the consequence that the input may not be entirely spec-compliant.This implements
BestAttemptforUniqueFileIdentifierFrame::parseand addsStrictchecks forVorbisCommentsparsing. More checks will come in the future.closes #204