Skip to content

Conversation

@Serial-ATA
Copy link
Owner

This adds an arbitrary allocation limit of 8MB for any one item, which should be more than enough in any case.

This was changed to stop the fuzz tests from failing with OOM errors.

This adds an arbitrary allocation limit of 8MB for any one item, which should be more than enough in any case.

This was changed to stop the fuzz tests from failing with OOM errors.
@hinto-janai
Copy link
Contributor

Does this include Picture's?

I'm sure I have some audio files with enormous embedded images (although probably not >8MB...?)

I'll scan all of them and report back.

@Serial-ATA
Copy link
Owner Author

Yeah, this includes pictures as well. I haven't encountered any image >8MB in my experience.

@hinto-janai
Copy link
Contributor

I have a few that are 5.1 MB. Is there a downside to increasing the limit to just before the fuzz tests start failing?

@Serial-ATA
Copy link
Owner Author

Serial-ATA commented Jun 4, 2023

The fuzz tests would OOM at different points depending on the system.

I think 8MB is probably a safe size. Having a single tag item >8MB seems a little crazy to me. Unless there's something I'm not thinking of.

Do note that the limit is arbitrary, it can always be increased later if it becomes an issue.

@hinto-janai
Copy link
Contributor

Ok, sounds good.

@Serial-ATA
Copy link
Owner Author

Actually, it wouldn't hurt to make this configurable in ParseOptions eventually. I'll make an issue for that.

@Serial-ATA Serial-ATA merged commit ea0e16c into main Jun 4, 2023
@Serial-ATA Serial-ATA deleted the alloc-limits branch June 4, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants