ID3v2: populate popularimeter tag from frame value #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! It might be better to use Could you also document the behavior here? 🙂 |
Contributor
Author
|
Hey, I've updated the PR to now use the binary encoding to preserve all fields of the tag. Documentation has been updated as suggested. I believe the existing documentation elsewhere already covers the expected behaviour, but I'm happy to update further if needed 🙂 |
Serial-ATA
reviewed
Aug 21, 2022
Owner
|
Hey @maneac, I just went ahead and made the changes to make sure this gets in |
Serial-ATA
changed the title
Serial-ATA
added a commit
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
ratingfield as the value of the Popularimeter tags when handling ID3v2 tags.closes #63