Skip to content

MP4: Allow to create AtomIdent constants with 'static lifetime #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Serial-ATA merged 1 commit into from
Jan 5, 2023
Merged

MP4: Allow to create AtomIdent constants with 'static lifetime #95

Serial-ATA merged 1 commit into from
Jan 5, 2023

Conversation

@uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Jan 4, 2023

Otherwise you would need to use once_cell for constants. This extension by using Cow also makes AtomIdentRef obsolete.

@Serial-ATA Serial-ATA merged commit d1bc6d4 into Serial-ATA:main Jan 5, 2023
@uklotzde uklotzde deleted the atomident branch January 5, 2023 19:13
@Serial-ATA Serial-ATA changed the title Allow to create AtomIdent constants with 'static lifetime MP4: Allow to create AtomIdent constants with 'static lifetime Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uklotzde @Serial-ATA