Update CMakeLists.txt to correct output directory for generated git v…#10
Merged
Update CMakeLists.txt to correct output directory for generated git v…#10
Conversation
…ersion and refine compile commands condition
- Changed the output directory for the generated git version from `${CMAKE_SOURCE_DIR}` to `${CMAKE_CURRENT_SOURCE_DIR}` to ensure proper path resolution.
- Updated the condition for exporting compile commands to check if the project is top-level, enhancing the build configuration logic.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the CMake configuration for the cpp-core library by addressing path resolution issues and enhancing build logic for use as a subdirectory. The changes ensure proper behavior both when building the project standalone and when it's included as a subdirectory of another project.
Key Changes:
- Updated the output directory for generated git version files to use
CMAKE_CURRENT_SOURCE_DIRinstead ofCMAKE_SOURCE_DIRfor correct path resolution - Added
PROJECT_IS_TOP_LEVELcheck to the compile commands export condition to prevent unwanted file copying when used as a subdirectory
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mqxx
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ersion and refine compile commands condition
${CMAKE_SOURCE_DIR}to${CMAKE_CURRENT_SOURCE_DIR}to ensure proper path resolution.