Enhance Version struct in get_version.h #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Katze719
commented
Dec 3, 2025
Katze719
commented
- Added new fields to the Version struct, including commit hash (short and full), commit date, branch, and version string, to provide comprehensive versioning information.
- This update improves the usability of version details within the codebase, aligning with recent enhancements in version management.
- Added new fields to the Version struct, including commit hash (short and full), commit date, branch, and version string, to provide comprehensive versioning information. - This update improves the usability of version details within the codebase, aligning with recent enhancements in version management.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Version struct in get_version.h by adding Git-related versioning information alongside the existing semantic version fields (major, minor, patch). The new fields provide comprehensive build-time versioning metadata including commit hashes, commit date, branch name, and a complete version string. This change aligns with the project's recent adoption of the cmake-git-versioning tool (configured in CMakeLists.txt) which generates these additional version constants at build time.
Key changes:
- Added five new const char* fields to the Version struct for Git metadata (commit hashes, date, branch, version string)
- Applied consistent alignment formatting to all struct fields following the project's clang-format conventions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Mqxx
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.