Use Correct HUD render event on 1.20.1#3
Open
decce6 wants to merge 1 commit into
Open
Conversation
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the 1.20.1 version of the mod listens to
RenderGuiOverlayEvent.Postto render the HUD. Unfortunately, as indicated by the "Overlay" part in the name, this event is posted every time an "overlay" is rendered (e.x. health bar, experience bar, hotbar, ...) Plus, mods are able to register their own overlays. This means in a large enough modpack, this mod's HUD may end up rendering 50+ times a frame! which bricks performance.The simple fix is to use
RenderGuiEvent.Post.This fix should be straightforward enough but it's not tested. Please provide build instructions as
(according to Serilum/.issue-tracker#2508 (comment) , either build Collective locally or use the jar on the maven.)gradlew builddoes not produce a usable mod jar.