Skip to content

CENS-79 - upgrade node to v20.20.0#111

Merged
jonasg-gc merged 1 commit intoServiceCanada:masterfrom
shiva-sc:upgrade-node
Feb 24, 2026
Merged

CENS-79 - upgrade node to v20.20.0#111
jonasg-gc merged 1 commit intoServiceCanada:masterfrom
shiva-sc:upgrade-node

Conversation

@shiva-sc
Copy link
Copy Markdown
Contributor

@shiva-sc shiva-sc commented Feb 5, 2026

No description provided.

@shiva-sc shiva-sc requested a review from a team February 5, 2026 20:18
@shiva-sc
Copy link
Copy Markdown
Contributor Author

shiva-sc commented Feb 5, 2026

@jonasg-gc : can you please review and merge this PR

Copy link
Copy Markdown
Contributor

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that some update would have been applied to the package-lock.json. Have you tried to update it by running "npm install" when the local node version is set to "20.20.0"?

Side note: This docker file are only for dev purpose, it should be use for production.

@jonasg-gc
Copy link
Copy Markdown
Collaborator

I would expect that some update would have been applied to the package-lock.json. Have you tried to update it by running "npm install" when the local node version is set to "20.20.0"?

Side note: This docker file are only for dev purpose, it should be use for production.

@shiva-sc : Please address @duboisp 's concerns re: package-lock.json

@shiva-sc
Copy link
Copy Markdown
Contributor Author

we are already executing "RUN npm install" in Dockerfile, and I don't see any new changes applied to package-lock.json file. Can you please suggest me, if I need to make any necessary changes to file?

@shiva-sc
Copy link
Copy Markdown
Contributor Author

@BeraJosh : can you please do security review and approve this PR

Copy link
Copy Markdown

@BeraJosh BeraJosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jonasg-gc jonasg-gc merged commit 1f6d367 into ServiceCanada:master Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants