This repository was archived by the owner on Jun 17, 2020. It is now read-only.
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Member
Author
|
observe that these are the same - percy build 1, percy build 2 |
…seed so that Percy sees the same thing every time
mermop
force-pushed
the
deterministic-faker-seed
branch
from
fae634f to
8fc5073
Compare
Br3nda
reviewed
Aug 29, 2019
Collaborator
Br3nda
left a comment
Br3nda
left a comment
There was a problem hiding this comment.
We can use Faker::Name.middle_name
Br3nda
reviewed
Aug 29, 2019
Collaborator
Br3nda
left a comment
Br3nda
left a comment
There was a problem hiding this comment.
Is there a way to make the names less Anglo?
…onLab/feijoa into deterministic-faker-seed
Member
Author
|
@Br3nda I have a faker PR to make NZ locale names reflect actual usage in NZ - changing it to the NZ locale should introduce a few Māori names but not that many right now - |
Br3nda
reviewed
Aug 29, 2019
…onLab/feijoa into deterministic-faker-seed
Br3nda
approved these changes
Aug 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the Faker seed so that we create names in the same order and stop confusing Percy - see Faker docs