Skip to content

Update constants.py#18

Merged
akshaykalkunte merged 1 commit intomainfrom
fix-gsm8k-typo
Sep 25, 2025
Merged

Update constants.py#18
akshaykalkunte merged 1 commit intomainfrom
fix-gsm8k-typo

Conversation

@oluwanifemibamgbose
Copy link
Copy Markdown
Collaborator

📌 Description

The gsm8k metric was added as a set instead of a tuple, which caused its loading and execution to fail.
This PR fixes that

🔗 Related Issue(s)

🛠️ Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality including new tasks)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor / Code cleanup
  • Maintenance / Chore / Task
  • Other (please describe):

✅ How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual testing

Test Results / Screenshots (if applicable):

📸 Screenshots / Demos

📋 Checklist

  • Code follows project style guidelines
  • Tests have been added/updated (if applicable)
  • Documentation has been updated (if applicable)
  • Linked relevant issue(s)
  • Self-reviewed my code

🙌 Additional Notes

Copy link
Copy Markdown
Collaborator

@akshaykalkunte akshaykalkunte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akshaykalkunte akshaykalkunte merged commit cdf4ca4 into main Sep 25, 2025
@akshaykalkunte akshaykalkunte deleted the fix-gsm8k-typo branch September 25, 2025 03:29
nhhoang96 added a commit that referenced this pull request Apr 18, 2026
* add gpqa diamond

* Update constants.py (#18)

* updating turn handling for multi-turn evals

* feat: Add Gemini support (#15)

* add spokenwoz speech and text (#24)

* add vllm configs and readme (#21)

* added phonetics, speech_disorder, and speech_enhancement tasks - stil… (#22)

* added phonetics, speech_disorder, and speech_enhancement tasks - still in need of full model scoring. Fixed small inconsistency bug in config by changing judge_properties to judge_settings.

* Update the correct HF path for noise_detection task

* updated scores

---------

Co-authored-by: hoang <huuhoang.nguyen@servicenow.com>

* voxtral and phi4 guidance (#25)

* Keeping normalizer up-to-date with Whisper-normalizer for ASR (#27)

* add gpqa diamond

---------

Co-authored-by: oluwanifemibamgbose <oluwanifemi.bamgbose@servicenow.com>
Co-authored-by: khyatimahajan <khyati.mahajan@servicenow.com>
Co-authored-by: Khyati Mahajan <mahajan.khyati@gmail.com>
Co-authored-by: Akshay Kalkunte <akshay.kalkunte@servicenow.com>
Co-authored-by: Jash Mehta <jash.mehta@servicenow.com>
Co-authored-by: Sidharth Surapaneni <40740959+pcsid@users.noreply.github.com>
Co-authored-by: hoang <huuhoang.nguyen@servicenow.com>
Co-authored-by: hoang <hnguy7@uic.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants