Conversation
ljang0
changed the title
gasse
suggested changes
Aug 29, 2024
gasse
changed the title
gasse
force-pushed
the
image_download
branch
from
9825db7 to
f9f2cc1
Compare
gasse
force-pushed
the
image_download
branch
from
6a5d5da to
4be7ad5
Compare
gasse
reviewed
Sep 25, 2024
gasse
force-pushed
the
image_download
branch
from
8d77ea0 to
639c674
Compare
gasse
reviewed
Sep 25, 2024
gasse
reviewed
Sep 25, 2024
browsergym/visualwebarena/src/browsergym/visualwebarena/task.py
Outdated
Show resolved
Hide resolved
recursix
reviewed
Sep 25, 2024
Collaborator
recursix
left a comment
recursix
left a comment
There was a problem hiding this comment.
Great job, But I'm really disappointed in the number of unit tests :p you will regret it.
browsergym/visualwebarena/src/browsergym/visualwebarena/task.py
Outdated
Show resolved
Hide resolved
recursix
previously approved these changes
Sep 25, 2024
TLSDC
reviewed
Oct 3, 2024
demo_agent/basic_agent.py
Outdated
| } | ||
| ) | ||
| elif msg["role"] == "user_image": | ||
| system_msgs.append({"type": "image_url", "image_url": msg["message"]}) |
Contributor
There was a problem hiding this comment.
Suggested change
| system_msgs.append({"type": "image_url", "image_url": msg["message"]}) | |
| user_msgs.append({"type": "image_url", "image_url": msg["message"]}) |
?
gasse
approved these changes
Oct 8, 2024
layahaasini
pushed a commit
to layahaasini/BrowserGym
that referenced
this pull request
Nov 21, 2025
--------- Co-authored-by: Thibault Le Sellier de Chezelles <thibault.de.chezelles@gmail.com> Co-authored-by: Maxime Gasse <maxime.gasse@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ThibaultLSDC can you check this?