Skip to content

Simpler pip info recording to logs#135

Merged
gasse merged 2 commits intomainfrom
gasse/patch_40
Sep 11, 2024
Merged

Simpler pip info recording to logs#135
gasse merged 2 commits intomainfrom
gasse/patch_40

Conversation

@gasse
Copy link
Copy Markdown
Contributor

@gasse gasse commented Sep 11, 2024

The use of subprocess was problematic when using joblib. This PR partially reverts #130

  • recording in the existing logfile instead of "pip_list.txt" and "pip_freeze.txt"
  • using importlib.metadata.distributions() instead of subprocess.check_output(["python", "-m", "pip", "list")

@gasse gasse requested a review from recursix September 11, 2024 15:58
recursix
recursix previously approved these changes Sep 11, 2024
@gasse gasse merged commit 2e96826 into main Sep 11, 2024
@gasse gasse deleted the gasse/patch_40 branch September 11, 2024 16:17
layahaasini pushed a commit to layahaasini/BrowserGym that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants