Skip to content

Show 20 similar utterances instead of 10#121

Merged
Dref360 merged 4 commits intodevfrom
hotfix/20_similar_utterances
Jun 7, 2022
Merged

Show 20 similar utterances instead of 10#121
Dref360 merged 4 commits intodevfrom
hotfix/20_similar_utterances

Conversation

@Dref360
Copy link
Copy Markdown
Contributor

@Dref360 Dref360 commented Jun 6, 2022

Description:

Fixes #89

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@Dref360 Dref360 requested a review from JosephMarinier June 6, 2022 20:01
Copy link
Copy Markdown
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not merge on dev? Can you please verify that the documentation does not need to be updated too?

@Dref360 Dref360 changed the base branch from main to dev June 7, 2022 02:00
@Dref360 Dref360 changed the base branch from dev to main June 7, 2022 02:00
@Dref360 Dref360 force-pushed the hotfix/20_similar_utterances branch from 6dc445d to 5fe2804 Compare June 7, 2022 13:08
@Dref360 Dref360 changed the base branch from main to dev June 7, 2022 13:08
@Dref360 Dref360 enabled auto-merge (squash) June 7, 2022 13:08
@Dref360 Dref360 merged commit f84612e into dev Jun 7, 2022
@Dref360 Dref360 deleted the hotfix/20_similar_utterances branch June 7, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align similarity smart tags with the number of neighbors displayed in the app (10 vs 20)

2 participants