Skip to content

Add documentation around custom utterances#143

Merged
Dref360 merged 1 commit intodevfrom
features/custom_utterances_documentation
Jun 13, 2022
Merged

Add documentation around custom utterances#143
Dref360 merged 1 commit intodevfrom
features/custom_utterances_documentation

Conversation

@Dref360
Copy link
Copy Markdown
Contributor

@Dref360 Dref360 commented Jun 13, 2022

Description:

Added a page around custom utterances, we support perturbation and saliency.

Found the following issues:

  • Fix some name collision around the name of the future
  • get_saliency wasn't getting pipeline_index
  • No need to check if the task is done, we never save the result.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@Dref360 Dref360 requested a review from gabegma June 13, 2022 21:37
Copy link
Copy Markdown
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!!

@Dref360 Dref360 merged commit 94cc329 into dev Jun 13, 2022
@Dref360 Dref360 deleted the features/custom_utterances_documentation branch June 13, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants