Skip to content

Smart tag families#145

Merged
JosephMarinier merged 51 commits intodevfrom
features/tag_family
Jun 20, 2022
Merged

Smart tag families#145
JosephMarinier merged 51 commits intodevfrom
features/tag_family

Conversation

@JosephMarinier
Copy link
Copy Markdown
Contributor

@JosephMarinier JosephMarinier commented Jun 14, 2022

Description:

Create smart tag families to group similar smart tags. Fixes #109

Screen Shot 2022-06-14 at 8 16 10 AM

Screen Shot 2022-06-14 at 8 24 32 AM

Screen Shot 2022-06-14 at 8 16 47 AM

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

Comment thread webapp/src/components/Controls/FilterSelector.tsx
Comment thread azimuth/types/model_performance.py Outdated
Comment thread azimuth/types/model_performance.py Outdated
Comment thread azimuth/types/tag.py Outdated
Comment thread azimuth/utils/pydantic_utils.py
Comment thread azimuth/utils/pydantic_utils.py
Comment thread azimuth/utils/pydantic_utils.py
Comment thread azimuth/types/model_performance.py
Comment thread azimuth/types/model_performance.py
Comment thread azimuth/routers/v1/utterances.py Outdated
Comment thread webapp/src/styles/theme.tsx
@gabegma
Copy link
Copy Markdown
Contributor

gabegma commented Jun 20, 2022

This is going to be wonderful!!

My main comment is regarding the utterance details UI. I would aim to have no hovering necessary on this page to know what is the full list of smart tag values. We had this comment from our users that hovering to get new information can be cumbersome.

As such, what I had in mind is to have no blue circles, and to display the name of the smart tag value instead of the name of the smart tag family. Hence, an icon would be there multiple times if more than one value is available within a family. We should discuss this, I'm curious what you think and our designers. Also, this could totally be done in a subsequent PR.

Screen Shot 2022-06-20 at 10 06 18 AM

Comment thread webapp/src/utils/const.ts
Comment thread webapp/src/components/Controls/Controls.tsx
Comment thread azimuth/types/utterance.py
Comment thread azimuth/types/utterance.py
Comment thread webapp/src/pages/UtteranceDetail.tsx
Comment thread webapp/src/components/Metrics/PerformanceAnalysis.tsx
@JosephMarinier JosephMarinier merged commit 579a61a into dev Jun 20, 2022
@JosephMarinier JosephMarinier deleted the features/tag_family branch June 20, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants