Smart tag families#145
Merged
JosephMarinier merged 51 commits intodevfrom Jun 20, 2022
Merged
Conversation
into `extreme_length` and `partial_syntax`
so that they are in the same order everywhere, and so that the families that are present without a pipeline are first.
…lineFilter` so that no field has to be `Optional` / `nullable`.
to support dynamic smart tags in the future.
JosephMarinier
commented
Jun 14, 2022
JosephMarinier
commented
Jun 16, 2022
JosephMarinier
commented
Jun 16, 2022
JosephMarinier
commented
Jun 16, 2022
JosephMarinier
commented
Jun 16, 2022
JosephMarinier
commented
Jun 16, 2022
JosephMarinier
commented
Jun 16, 2022
JosephMarinier
commented
Jun 16, 2022
JosephMarinier
commented
Jun 16, 2022
JosephMarinier
commented
Jun 16, 2022
Contributor
|
This is going to be wonderful!! My main comment is regarding the utterance details UI. I would aim to have no hovering necessary on this page to know what is the full list of smart tag values. We had this comment from our users that hovering to get new information can be cumbersome. As such, what I had in mind is to have no blue circles, and to display the name of the smart tag value instead of the name of the smart tag family. Hence, an icon would be there multiple times if more than one value is available within a family. We should discuss this, I'm curious what you think and our designers. Also, this could totally be done in a subsequent PR. |
JosephMarinier
commented
Jun 20, 2022
JosephMarinier
commented
Jun 20, 2022
christyler3030
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
Create smart tag families to group similar smart tags. Fixes #109
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.
ran
pre-commit run --all-filesat the end.Run
cd webapp && yarn typeswhile the back-end is running.our users.
READMEfiles and our wiki for any big design decisions, if relevant.