Skip to content

Add F1#155

Merged
JosephMarinier merged 8 commits intodevfrom
features/add_d1
Jun 21, 2022
Merged

Add F1#155
JosephMarinier merged 8 commits intodevfrom
features/add_d1

Conversation

@JosephMarinier
Copy link
Copy Markdown
Contributor

@JosephMarinier JosephMarinier commented Jun 20, 2022

Resolves #124 and resolves #147

Description:

  • Add F1 to default config.
  • Use outcomes' icons as headers of the Performance Overview table instead of the outcomes' full names.
  • Fix table "overall" row not on top at initial load, by controlling the sort model instead of trying to keep a reference to it (and setting the initial state).

image
image

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@JosephMarinier JosephMarinier self-assigned this Jun 20, 2022
@JosephMarinier JosephMarinier linked an issue Jun 20, 2022 that may be closed by this pull request
@JosephMarinier JosephMarinier mentioned this pull request Jun 20, 2022
@gabegma
Copy link
Copy Markdown
Contributor

gabegma commented Jun 21, 2022

It looks great!! Are the complete names available while hovering the icons?

Comment thread webapp/src/components/Icons/outcomeIcon.tsx
by controlling the sort model instead of trying to keep a reference to it (and setting the initial state).

Resolves #147
Comment thread webapp/src/components/Icons/outcomeIcon.tsx Outdated
@JosephMarinier JosephMarinier merged commit 0aad890 into dev Jun 21, 2022
@JosephMarinier JosephMarinier deleted the features/add_d1 branch June 21, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix performance analysis table overall row not on top at initial load Add F1 Metric

3 participants