Add pipeline comparison smart tag family#161
Merged
JosephMarinier merged 4 commits intodevfrom Jul 7, 2022
Merged
Conversation
with pipeline disagreement smart tag
Collaborator
christyler3030
left a comment
christyler3030
left a comment
There was a problem hiding this comment.
Frontend looks good. nice svg wrangling
nandhinibsn
reviewed
Jul 7, 2022
Contributor
nandhinibsn
left a comment
nandhinibsn
left a comment
There was a problem hiding this comment.
Changes looks good to me.. Good learning on the svg icon!.
Contributor
Author
|
Cool! Thank you guys! |
gabegma
reviewed
Jul 7, 2022
Contributor
gabegma
left a comment
gabegma
left a comment
There was a problem hiding this comment.
We are missing one smart tag! The front-end looks so good though.
gabegma
reviewed
Jul 7, 2022
gabegma
approved these changes
Jul 7, 2022
Contributor
gabegma
left a comment
gabegma
left a comment
There was a problem hiding this comment.
Awesome, I'll approve for the group!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
pipeline_disagreementandincorrect_for_all_pipelinessmart tagsChecklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.
ran
pre-commit run --all-filesat the end.Run
cd webapp && yarn typeswhile the back-end is running.our users.
READMEfiles and our wiki for any big design decisions, if relevant.