Skip to content

Various fixes before releasing#163

Merged
JosephMarinier merged 4 commits intodevfrom
joseph/fixes
Jul 8, 2022
Merged

Various fixes before releasing#163
JosephMarinier merged 4 commits intodevfrom
joseph/fixes

Conversation

@JosephMarinier
Copy link
Copy Markdown
Contributor

@JosephMarinier JosephMarinier commented Jul 8, 2022

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

The width of the selector in the table column is no longer hardcoded thanks to the `fullWidth` prop. The width in the table footer still needs to be fixed though, so I set it to the longest option "augment_with_similar".
@JosephMarinier JosephMarinier self-assigned this Jul 8, 2022
@JosephMarinier JosephMarinier enabled auto-merge (squash) July 8, 2022 20:01
Copy link
Copy Markdown
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!! All issues were fixed in the demo.

@JosephMarinier JosephMarinier merged commit 18d54ab into dev Jul 8, 2022
@JosephMarinier JosephMarinier deleted the joseph/fixes branch July 8, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants