Move confidence threshold out of /dataset_info#61
Merged
JosephMarinier merged 4 commits intodevfrom Jun 16, 2022
Merged
Conversation
Dref360
approved these changes
May 26, 2022
2d9e21f to
848cddd
Compare
JosephMarinier
commented
May 26, 2022
Contributor
Author
There was a problem hiding this comment.
@Dref360, could you advise on the "two approaches" I mentioned in the PR description? Are both OK?
- I tried two approaches to get some feedback:
- For/utterances, I get the confidence threshold in the router.
- For/bins, I get the confidence threshold in the module. I have some trouble withpipeline_index. Before investing more time, is that even a sensible approach?
Contributor
There was a problem hiding this comment.
Yeah, to me it makes sense to return the threshold in a router OR in a Module depending on the usecase. The way you did it is great!
Contributor
|
Can we merge this? |
and into `/bins` and `/utterances`. The idea is to remove pipeline-specific info from `/dataset_info`.
848cddd to
385511b
Compare
4f3ab37 to
0684415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The idea is to remove pipeline-specific info from
/dataset_info./dataset_infoand into/binsand/utterances/utterances, I get the confidence threshold in the router./bins, I get the confidence threshold in the module. I have some trouble withpipeline_index. Before investing more time, is that even a sensible approach?Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.
ran
pre-commit run --all-filesat the end.Run
cd webapp && yarn typeswhile the back-end is running.our users.
READMEfiles and our wiki for any big design decisions, if relevant.