Skip to content

Toggle normalized confusion matrix#86

Merged
nandhinibsn merged 15 commits intodevfrom
PR/nandhini/ToggleNormalized
Jun 8, 2022
Merged

Toggle normalized confusion matrix#86
nandhinibsn merged 15 commits intodevfrom
PR/nandhini/ToggleNormalized

Conversation

@nandhinibsn
Copy link
Copy Markdown
Contributor

@nandhinibsn nandhinibsn commented Jun 1, 2022

Description: Added a new feature to normalize/not normalize confusion matrix data

Fixes #115

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

Copy link
Copy Markdown
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review the code - but it should merged on dev, not on main :)

@nandhinibsn nandhinibsn changed the base branch from main to dev June 1, 2022 22:02
@nandhinibsn nandhinibsn force-pushed the PR/nandhini/ToggleNormalized branch from fc458d3 to 4a1a732 Compare June 1, 2022 22:05
@nandhinibsn
Copy link
Copy Markdown
Contributor Author

nandhinibsn commented Jun 1, 2022

Rebased on origin/dev

Comment thread webapp/src/components/ConfusionMatrix.tsx Outdated
Comment thread webapp/src/utils/helpers.ts Outdated
Comment thread webapp/src/components/ConfusionMatrix.tsx Outdated
@nandhinibsn
Copy link
Copy Markdown
Contributor Author

If normalized:
image
If not normalized:
image

Comment thread azimuth/types/model_performance.py Outdated
Comment thread azimuth/routers/v1/model_performance/confusion_matrix.py Outdated
@nandhinibsn nandhinibsn force-pushed the PR/nandhini/ToggleNormalized branch from 3322f39 to e4fcaa9 Compare June 7, 2022 14:11
Comment thread azimuth/routers/v1/model_performance/confusion_matrix.py Outdated
Comment thread tests/test_modules/test_model_performance/test_confusion_matrix.py Outdated
Comment thread tests/test_modules/test_model_performance/test_confusion_matrix.py Outdated
Comment thread webapp/src/components/ConfusionMatrix.tsx Outdated
which is our best guess of what the `normalized` state will be.
@JosephMarinier JosephMarinier changed the title Pr/nandhini/toggle normalized Toggle normalized confusion matrix Jun 8, 2022
@nandhinibsn nandhinibsn merged commit aa1b57d into dev Jun 8, 2022
@nandhinibsn nandhinibsn deleted the PR/nandhini/ToggleNormalized branch June 8, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants