Run all metrics by default#96
Merged
JosephMarinier merged 12 commits intomainfrom Apr 29, 2026
Merged
Conversation
Revert `_redact_api_keys()` from #45, duplicated with the existing `_redact_model_params()`.
(this would fail without the previous commit)
which is also run in the CI, so it never gets out of sync again.
katstankiewicz
approved these changes
Apr 29, 2026
Remove simulation and metrics versions from pyproject.toml, as they are redundant with `src/eva/__init__.py` and out of sync since 5f4bb76.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I included a few small things before the default metrics. Let me know if anything is worth discussing in a separate PR.
uv.locknever gets out of sync again.src/eva/__init__.pysrc/eva/__init__.pyand out of sync since 5f4bb76._redact_api_keys()from Pr/configurable turn options #45, duplicated with the existing_redact_model_params()ors left after this in make model required for all services #50eva: error: unrecognized arguments: ..., so this shouldn't cause silent errors.--metric=(work around a bug in Pydantic)