Implement Lane D finalize workflow with canonical records#32
Merged
Am1n3e merged 1 commit intofeature/add-leaderboardfrom Mar 7, 2026
Merged
Implement Lane D finalize workflow with canonical records#32Am1n3e merged 1 commit intofeature/add-leaderboardfrom
Am1n3e merged 1 commit intofeature/add-leaderboardfrom
Conversation
Am1n3e
commented
Mar 7, 2026
| ) | ||
|
|
||
|
|
||
| class FinalizeContext(BaseModel): |
Contributor
Author
There was a problem hiding this comment.
move models to a different files (model.py)
Am1n3e
commented
Mar 7, 2026
| _MISSING_SENTINEL_FILE = ".missing" | ||
| _AGENT_RESPONSE_FILE = "agent_response.json" | ||
| _NETWORK_HAR_FILE = "network.har" | ||
| _SITE_KEYS = ("shopping", "reddit", "gitlab", "wikipedia", "map", "shopping_admin") |
Contributor
Author
There was a problem hiding this comment.
Use the str enum WebArenaSite.
Am1n3e
commented
Mar 7, 2026
| if TYPE_CHECKING: | ||
| from pathlib import Path | ||
|
|
||
| _INTAKE_PREFIX = "submissions/inbox/" |
Contributor
Author
There was a problem hiding this comment.
We need to use pydantic-settings for this
Am1n3e
commented
Mar 7, 2026
|
|
||
| repo_quoted = parse.quote(repo, safe="") | ||
| while True: | ||
| url = f"https://api.github.com/repos/{repo_quoted}/pulls/{pr_number}/files?per_page=100&page={page}" |
Contributor
Author
There was a problem hiding this comment.
add and use pygithub library
Am1n3e
force-pushed
the
wip/implementation-plan
branch
from
4b8f6ac to
39f141b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
leaderboard-submissionsthat canonicalizes intake payloads, uploads canonical snapshots to HF, writessubmissions/<submission_id>.json, and removes inbox foldersValidation
uv run ruff check dev/leaderboard/finalize.py dev/leaderboard/tasks.py src/webarena_verified/types/leaderboard/submission_record.py tests/leaderboard/test_finalize.py tests/types/test_leaderboard_types.pyuv run pytest tests/leaderboard/test_finalize.py tests/types/test_leaderboard_types.pyuv run inv --list dev.leaderboard