Skip to content

Conversation

@NavyasreeBolleboyana
Copy link
Contributor

PR Description:

Pull Request Checklist

Overview

  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@Atul-LNG Atul-LNG self-assigned this Oct 7, 2025
Copy link
Contributor

@Atul-LNG Atul-LNG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NavyasreeBolleboyana
Thanks for your participation.

A few points to note:

The README file states that a Problem record should be created when the category is "Hardware." However, to clarify, not every hardware-related incident necessarily requires a Problem record to be created.

You checked in 3 files. It's unclear what the purpose of department_filter.js is—it seems like an extra file that might have been checked in by mistake.

@NavyasreeBolleboyana
Copy link
Contributor Author

@Atul-LNG , Thanks for the feedback! I’ve modified the README to clarify the note about hardware-related incidents. Please review the changes.

@Atul-LNG
Copy link
Contributor

Atul-LNG commented Oct 7, 2025

Thanks @NavyasreeBolleboyana for update. let me review.

@Atul-LNG Atul-LNG merged commit 55cae26 into ServiceNowDevProgram:main Oct 7, 2025
1 check passed
Atul-LNG added a commit that referenced this pull request Oct 7, 2025
rohi-v pushed a commit that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants