Skip to content

Commit 394ab9c

Browse files
phifoggphifogg
authored
Merge branch 'master' into rootScope-listener
2 parents e186b31 + 54567c5 commit 394ab9c

14 files changed

+712
-1
lines changed

‎README.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ Validates the description of the update sets created is not empty as it provides
5555
### Update set should not have more than 1000 updates
5656
Update sets with more than 1000 configuration updates should be broken down into multiple update sets with batching or the parent story has to be more granular as reviewing update set configs and commiting/backing out may have issues.
5757

58+
### Updates in wrong update set scope
59+
The scope for Customer Update [sys_update_xml] records should match the scope of the Update Set in which the Customer Update resides. Having a mismatch may cause Update Sets to generate preview errors meaning you cannot commit them until the errors are resolved.
60+
5861
## Category: Upgradability
5962

6063
### Incident table should not be extended
@@ -130,6 +133,14 @@ Improper use of eval() opens up your code for injection attacks and difficulties
130133
### Do not use gr as a variable name
131134
The platform is Javascript and a lot of code is run in a global variable scope. A "gr" defined in one business rule can clobber another "gr" defined in some other script.
132135

136+
### Admins not logged in for 1 month
137+
Monitor users with role `admin` (not locked out) that are not logged for longer than 1 month
138+
139+
### Users left in already inactivated Groups
140+
After deactivation of Groups there can be still some users.
141+
Group offer membership but also can provide some roles that after deactivation should be considered as no longer needed.
142+
143+
133144
## Category: User Experience
134145

135146

‎ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
yRAdTrGPYVvbipt43BmROzovwtdi4W98Y5fFAze6fNNug4Cx3bErlpOqhYtVhTgKZ8AGOWD_laPP6Y_z3BkW3nZC5nPMERnWyLZxn9aFu28NzucCBgvKjh9uJjESImB96SIj57wK8nWFNMgaL2ZvJgvHdNbChkkntSmBsV_r7s1cALvOeZPpBAEGYJiZ7mOPr7_pz4-YwFlfsfUyO4jEDhRW283uhIAJPvOHdwM6TlHuwhTnp4O6kUYbZVZV8ee-6-0NWY_9nG1nFbOPN9AJ-itOsP-9Gd1YoyOqjm9fpMgUUk3zt4YPsK6-_6VBFPOC1itrqn0SeKaHzVEDPej2gYFCpYgGbVHdhWEDbxt8I_3Ed3IDg48Pad2lqDk69V4gz4ZLvhLmDUjA0Q7jQt0B3cVzZCQGK4M8BMHIt3D9LVb2D3XsNwaX-kNFu5Zzo3spUJgK9KfPo8s2erHd1-nq_ICJkL836gARdWMNefu3TZoAcRR9-PPzZzaH16HvuFAtzSjqVC_NtMrsWBOe0xlhl_gyTdjgu8MAPWDAsnGtpeAEmfxOEBqB4-R8S_vl4K1WEU5MU-SgK2mvFn136KvWp-43Tr3Qmn3DpYsz9NFNw5RD04cTWCQo_sip4sgK9etOqlceQTE5S2ZV5zQxJDVFQMNvv7Bl1HyEf8u_nSolCwQ
1+
pAcfdvfkVBvdcNK_HZ6Siz27BK483rysXEEssjGG27O7HfaiuDjvSeRhd0EZeVUudSzZU3oflCzpya9lTPGvDX8xgLV8BWFmL28KpbfEO9wDhxF3vjVDzgTvgZvMxTWLDKnni98ffRF_Fq1G8VDsxnVPHbv_zZSqg_uHdNPqSkKQFMJqID-neTU1JafKdsy5ugT-D7ES8hizMmLyhvApTtXYOArMEjy20glEcvh5TjcIA1u5bCRdoykZ2x79e0zcKCE76z3i7OO2ryCkiYpkIApRPOu3Z_tTcYnzQHssAekDqNtqWnsHt_QBTA9Jcpjlg48GXm47o13_1EiTQeO6XV-gl-ahpZdlBsqBIwMDiLKSveC9m2Un5s8kIz0Jq8tdhiJgiqmyP8MR2yPyYT5NkcB8OCDSn-MyIHI0ROLvKZd88WhN-jU4YGmGMdL2D-QQHnir6CXIW-uXOZ00FF6snv89TqARUGM7DJg3VL1t1uVCa8nmJQ53YKNg9C-3hC4fdZ_uB1ynKFcoAKROPTyCD58PnQHfMjDYG3BqEa-apGBAo3XsU0zI1wdS00Ia4kS1TcV4kozt_SZJZVYIPEpJ262IKgnxuOQQjDN4J6DVitEeBuefiClEGRCbIHzdyUiLvoI8Wv2gQ0a00MRkmi3ReOT1MNSYL3ODnvaNL_gdZho

‎ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_3b163adc2f9bb4505dcb59ab2799b616.xml‎

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
2+
<scan_table_check action="INSERT_OR_UPDATE">
3+
<active>true</active>
4+
<advanced>false</advanced>
5+
<attributes/>
6+
<category>manageability</category>
7+
<conditions table="sys_update_xml">applicationNSAMEASupdate_set.application^EQ<item endquery="false" field="application" goto="false" newquery="false" operator="NSAMEAS" or="false" value="update_set.application"/>
8+
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
9+
</conditions>
10+
<description>Updates in the wrong update set scope may generate an error like the following when previewed: &#13;
11+
&#13;
12+
Cannot commit Update Set 'UPDATE_SET_NAME' because: Update scope id 'x' is different than update set scope id 'y'. Resolve the problem before committing.</description>
13+
<documentation_url/>
14+
<finding_type>scan_finding</finding_type>
15+
<name>Updates in wrong update set scope</name>
16+
<priority>2</priority>
17+
<resolution_details>The scope of the Customer Update [sys_update_xml] record should match the scope of the Update Set in which it resides.</resolution_details>
18+
<run_condition/>
19+
<score_max>100</score_max>
20+
<score_min>0</score_min>
21+
<score_scale>1</score_scale>
22+
<script><![CDATA[(function (engine) {
23+
24+
// Add your code here
25+
26+
})(engine);]]></script>
27+
<short_description>Updates in wrong update set scope</short_description>
28+
<sys_class_name>scan_table_check</sys_class_name>
29+
<sys_created_by>nia.mccash</sys_created_by>
30+
<sys_created_on>2021-10-15 20:50:09</sys_created_on>
31+
<sys_id>3b163adc2f9bb4505dcb59ab2799b616</sys_id>
32+
<sys_mod_count>1</sys_mod_count>
33+
<sys_name>Updates in wrong update set scope</sys_name>
34+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
35+
<sys_policy/>
36+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
37+
<sys_update_name>scan_table_check_3b163adc2f9bb4505dcb59ab2799b616</sys_update_name>
38+
<sys_updated_by>nia.mccash</sys_updated_by>
39+
<sys_updated_on>2021-10-23 23:25:03</sys_updated_on>
40+
<table>sys_update_xml</table>
41+
<use_manifest>false</use_manifest>
42+
</scan_table_check>
43+
</record_update>

‎ca8467c41b9abc10ce0f62c3b24bcbaa/update/sys_relationship_55e9076607933850be01f03c7c1ed0b2.xml‎

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="sys_relationship">
2+
<sys_relationship action="INSERT_OR_UPDATE">
3+
<advanced>false</advanced>
4+
<apply_to/>
5+
<basic_apply_to>sys_update_set</basic_apply_to>
6+
<basic_query_from>scan_finding</basic_query_from>
7+
<insert_callback/>
8+
<name>Latest Scan Findings</name>
9+
<query_from/>
10+
<query_with><![CDATA[(function refineQuery(current, parent) {
11+
12+
var grTarget = new GlideRecord('scan_target');
13+
if (grTarget.get('record_id', parent.getUniqueValue())) {
14+
var targetId = grTarget.getUniqueValue();
15+
var arrComboIds = [];
16+
var grCombo = new GlideRecord('scan_combo');
17+
grCombo.addQuery('targets', 'IN', targetId);
18+
grCombo.query();
19+
while (grCombo.next()) {
20+
arrComboIds.push(grCombo.getUniqueValue());
21+
}
22+
var grResult = new GlideRecord('scan_result');
23+
grResult.addQuery('combo', 'IN', arrComboIds.toString());
24+
grResult.orderByDesc('sys_created_on');
25+
grResult.setLimit(1);
26+
grResult.query();
27+
if (grResult.next()) {
28+
current.addQuery('result', grResult.getUniqueValue());
29+
} else {
30+
current.addQuery('sys_id', '-1');
31+
}
32+
33+
} else {
34+
current.addQuery('sys_id', '-1');
35+
}
36+
37+
38+
})(current, parent);]]></query_with>
39+
<reference_field>check</reference_field>
40+
<related_list/>
41+
<simple_reference>false</simple_reference>
42+
<sys_class_name>sys_relationship</sys_class_name>
43+
<sys_created_by>w.geek6</sys_created_by>
44+
<sys_created_on>2021-10-22 22:02:53</sys_created_on>
45+
<sys_id>55e9076607933850be01f03c7c1ed0b2</sys_id>
46+
<sys_mod_count>1</sys_mod_count>
47+
<sys_name>Latest Scan Findings</sys_name>
48+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
49+
<sys_policy/>
50+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
51+
<sys_update_name>sys_relationship_55e9076607933850be01f03c7c1ed0b2</sys_update_name>
52+
<sys_updated_by>w.geek6</sys_updated_by>
53+
<sys_updated_on>2021-10-22 22:04:12</sys_updated_on>
54+
</sys_relationship>
55+
<sys_translated_text action="delete_multiple" query="documentkey=55e9076607933850be01f03c7c1ed0b2"/>
56+
<sys_ui_related_list_relationship_entry action="INSERT_OR_UPDATE">
57+
<filter/>
58+
<list_id display_value="Update Set - Default view" name="sys_update_set" related_list="NULL" sys_domain="global" view="Default view">13cee3c347231200c17e19fbac9a7139</list_id>
59+
<order_by/>
60+
<position>7</position>
61+
<related_list>REL:55e9076607933850be01f03c7c1ed0b2</related_list>
62+
<sys_class_name>sys_ui_related_list_relationship_entry</sys_class_name>
63+
<sys_created_by>w.geek6</sys_created_by>
64+
<sys_created_on>2021-10-22 22:03:06</sys_created_on>
65+
<sys_id>18f9476607933850be01f03c7c1ed048</sys_id>
66+
<sys_mod_count>0</sys_mod_count>
67+
<sys_relationship display_value="Latest Scan Findings">55e9076607933850be01f03c7c1ed0b2</sys_relationship>
68+
<sys_ui_related_list display_value="Update Set - Default view" name="sys_update_set" related_list="NULL" sys_domain="global" view="Default view">13cee3c347231200c17e19fbac9a7139</sys_ui_related_list>
69+
<sys_updated_by>w.geek6</sys_updated_by>
70+
<sys_updated_on>2021-10-22 22:03:06</sys_updated_on>
71+
</sys_ui_related_list_relationship_entry>
72+
</record_update>

‎ca8467c41b9abc10ce0f62c3b24bcbaa/update/sys_relationship_62b6cf6207933850be01f03c7c1ed06d.xml‎

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="sys_relationship">
2+
<sys_relationship action="INSERT_OR_UPDATE">
3+
<advanced>false</advanced>
4+
<apply_to/>
5+
<basic_apply_to>sys_scope</basic_apply_to>
6+
<basic_query_from>scan_result</basic_query_from>
7+
<insert_callback/>
8+
<name>Scan Results</name>
9+
<query_from/>
10+
<query_with><![CDATA[(function refineQuery(current, parent) {
11+
12+
var grTarget = new GlideRecord('scan_target');
13+
if (grTarget.get('record_id', parent.getUniqueValue())) {
14+
var targetId = grTarget.getUniqueValue();
15+
var arrComboIds = [];
16+
var grCombo = new GlideRecord('scan_combo');
17+
grCombo.addQuery('targets', 'IN', targetId);
18+
grCombo.query();
19+
while (grCombo.next()) {
20+
arrComboIds.push(grCombo.getUniqueValue());
21+
}
22+
current.addQuery('combo', 'IN', arrComboIds.toString());
23+
}
24+
else {
25+
current.addQuery('sys_id', '-1');
26+
}
27+
28+
29+
})(current, parent);]]></query_with>
30+
<reference_field>combo</reference_field>
31+
<related_list/>
32+
<simple_reference>false</simple_reference>
33+
<sys_class_name>sys_relationship</sys_class_name>
34+
<sys_created_by>w.geek6</sys_created_by>
35+
<sys_created_on>2021-10-22 21:49:33</sys_created_on>
36+
<sys_id>62b6cf6207933850be01f03c7c1ed06d</sys_id>
37+
<sys_mod_count>2</sys_mod_count>
38+
<sys_name>Scan Results</sys_name>
39+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
40+
<sys_policy/>
41+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
42+
<sys_update_name>sys_relationship_62b6cf6207933850be01f03c7c1ed06d</sys_update_name>
43+
<sys_updated_by>w.geek6</sys_updated_by>
44+
<sys_updated_on>2021-10-22 21:54:11</sys_updated_on>
45+
</sys_relationship>
46+
<sys_translated_text action="delete_multiple" query="documentkey=62b6cf6207933850be01f03c7c1ed06d"/>
47+
<sys_ui_related_list_relationship_entry action="INSERT_OR_UPDATE">
48+
<filter/>
49+
<list_id display_value="Store Application - Default view" name="sys_store_app" related_list="NULL" sys_domain="global" view="Default view">ef51849077311010ca93aeca78106100</list_id>
50+
<order_by/>
51+
<position>3</position>
52+
<related_list>REL:62b6cf6207933850be01f03c7c1ed06d</related_list>
53+
<sys_class_name>sys_ui_related_list_relationship_entry</sys_class_name>
54+
<sys_created_by>w.geek6</sys_created_by>
55+
<sys_created_on>2021-10-22 21:54:30</sys_created_on>
56+
<sys_id>22f7cfe207933850be01f03c7c1ed095</sys_id>
57+
<sys_mod_count>0</sys_mod_count>
58+
<sys_relationship display_value="Scan Results">62b6cf6207933850be01f03c7c1ed06d</sys_relationship>
59+
<sys_ui_related_list display_value="Store Application - Default view" name="sys_store_app" related_list="NULL" sys_domain="global" view="Default view">ef51849077311010ca93aeca78106100</sys_ui_related_list>
60+
<sys_updated_by>w.geek6</sys_updated_by>
61+
<sys_updated_on>2021-10-22 21:54:30</sys_updated_on>
62+
</sys_ui_related_list_relationship_entry>
63+
<sys_ui_related_list_relationship_entry action="INSERT_OR_UPDATE">
64+
<filter/>
65+
<list_id display_value="Application - Default view" name="sys_scope" related_list="NULL" sys_domain="global" view="Default view">0ce24420d701310092610eca5e6103f1</list_id>
66+
<order_by/>
67+
<position>1</position>
68+
<related_list>REL:62b6cf6207933850be01f03c7c1ed06d</related_list>
69+
<sys_class_name>sys_ui_related_list_relationship_entry</sys_class_name>
70+
<sys_created_by>w.geek6</sys_created_by>
71+
<sys_created_on>2021-10-22 21:54:30</sys_created_on>
72+
<sys_id>6ef7cfe207933850be01f03c7c1ed093</sys_id>
73+
<sys_mod_count>0</sys_mod_count>
74+
<sys_relationship display_value="Scan Results">62b6cf6207933850be01f03c7c1ed06d</sys_relationship>
75+
<sys_ui_related_list display_value="Application - Default view" name="sys_scope" related_list="NULL" sys_domain="global" view="Default view">0ce24420d701310092610eca5e6103f1</sys_ui_related_list>
76+
<sys_updated_by>w.geek6</sys_updated_by>
77+
<sys_updated_on>2021-10-22 21:54:30</sys_updated_on>
78+
</sys_ui_related_list_relationship_entry>
79+
<sys_ui_related_list_relationship_entry action="INSERT_OR_UPDATE">
80+
<filter/>
81+
<list_id display_value="Custom Application - Default view" name="sys_app" related_list="NULL" sys_domain="global" view="Default view">adb9cea3c3301200f7d1ca3adfba8fe0</list_id>
82+
<order_by/>
83+
<position>5</position>
84+
<related_list>REL:62b6cf6207933850be01f03c7c1ed06d</related_list>
85+
<sys_class_name>sys_ui_related_list_relationship_entry</sys_class_name>
86+
<sys_created_by>w.geek6</sys_created_by>
87+
<sys_created_on>2021-10-22 21:49:33</sys_created_on>
88+
<sys_id>c2d64b6207933850be01f03c7c1ed09f</sys_id>
89+
<sys_mod_count>0</sys_mod_count>
90+
<sys_relationship display_value="Scan Results">62b6cf6207933850be01f03c7c1ed06d</sys_relationship>
91+
<sys_ui_related_list display_value="Custom Application - Default view" name="sys_app" related_list="NULL" sys_domain="global" view="Default view">adb9cea3c3301200f7d1ca3adfba8fe0</sys_ui_related_list>
92+
<sys_updated_by>w.geek6</sys_updated_by>
93+
<sys_updated_on>2021-10-22 21:49:33</sys_updated_on>
94+
</sys_ui_related_list_relationship_entry>
95+
</record_update>

0 commit comments

Comments
 (0)