Contributing! #12
Merged
Contributing! #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markroethof
commented
Oct 7, 2021
markroethof
commented
- Adding four (4) best practices related scan checks.
- Added active flag on "Avoid Global Client Scripts". Fixed code mistake on "Cache flushed as part of scripts" (line 15, should be "childnode" instead of "node")
- Five (5) example "Sanity Test" Scan Checks. Scan Checks which you could run on a daily basis (or more frequent), Scan Checks for which you might set up monitoring, Scan Checks which could be typical Administrator tasks.
added 3 commits
October 2, 2021 10:28
Fixed code mistake on "Cache flushed as part of scripts" (line 15, should be "childnode" instead of "node")
…ld run on a daily basis (or more frequent), Scan Checks for which you might set up monitoring, Scan Checks which could be typical Administrator tasks.
Collaborator
|
Hi Mark, can you update the readme.md with your new checks? Thanks! |
Contributor
|
I think Mark's readme update was in PR #16 but the code is here and still needs to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.