Fixed connection string parsing issue with UNC pathes

[pysco68]

The issue can be fixed by setting the constructor parameter "parseViaFramework" of SQLiteConnection to true.

Only few documentation is available about that change that was apparently introduced with bugfix http://sqlite.1065341.n5.nabble.com/3-7-7-URI-filenames-and-UNC-paths-td6893.html

N.B.: I don't know wether or not the Mono version is affected.

[mythz]

Can you provide the failing test that this fixes please.

[pysco68]

I'm taking a look at it, but I'm afraid it'll be hard to test because the test would certainly rely on environment conditions, as I discovered the bug trying to save the database on a path like \server\folder\xxxx (a windows share, not being mounted as network drive)

[pysco68]

I didn't find any practical way of simulating a UNC path. I can't think of a way of solving this. Sorry.

[mythz]

ok but how do we know this change is safe and doesn't break anything?

[KevinHoward]

http://stackoverflow.com/questions/16768415/system-data-sqlite-parseviaframework

It appears that this new "parseViaFramework" parameter for the SQLiteConnection constructor was created to address a completely different issue, so I can see @mythz concerns.

Do both of you feel that building unit tests and code changes around the issue it did solve would suffice to addressing the changes for the UNC paths?

[mythz]

Right, I don't like changing default behavior without any assurances. In the meantime lets add a static field that's defaults to false on SqliteOrmLiteDialectProviderBase and use that in the constructor.

[pysco68]

Sure that would help, and I fully understand the point of wanting some insurance, but I really don't know how one should build a test case for that one (I mean that I'm not aware about any shared folder that is always available, plus that test would be windows only).

I'd be happy to help further if s someone gives me a hint.

Demis Bellot notifications@github.com schrieb:

I don't like changing default behavior without any assurances. In the meantime lets add a static field that's defaults to false on SqliteOrmLiteDialectProviderBase.

---

Reply to this email directly or view it on GitHub:
#290 (comment)

[mythz]

Ok this should do it: 6773868

You need to set SqliteOrmLiteDialectProviderBase.ParseViaFramework = true before you connect.