This repository has been archived by the owner on Dec 24, 2022. It is now read-only.
Fully unescape string before decoding base64 to byte[] #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythz
added a commit
that referenced
this pull request
Apr 24, 2014
Fully unescape string before decoding base64 to byte[]
|
Great! appreciated 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our server json serializer (Jersey) generates escaped slashes in our byte[]'s base64. I switched to the unsafe string decode when decoding byte[] and added a test that fails otherwise. I added some escape characters to a few other tests along the way and left them in since they make the tests just a pinch more robust.
Thanks a lot for your work on this killer library :)