This repository was archived by the owner on Dec 24, 2022. It is now read-only.
Fix JsConfig<T> to run T's static constructor first #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce the static constructor may set OnDeserialized, etc.
Member
|
Hi, can you approve the Contributor License Agreement so we can look at merging this, thx. |
mythz
added a commit
that referenced
this pull request
Dec 13, 2015
Fix JsConfig<T> to run T's static constructor first
Member
|
Thanks for PR, this change is available from v4.0.51 that's now available on MyGet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing a type from JSV the type's static constructor was sometimes not called before the JsConfig for that type is cached. This was problematic when the static constructor sets JsConfig.OnDeserialized (which is the obvious place to set it), because OnDeserialized then does not get called and the type is not deserialized correctly. The included unit test demonstrates this problem.
Also fixed some unrelated unit tests that were failing on my machine due to timezone differences.