This repository was archived by the owner on Dec 24, 2022. It is now read-only.
JsonSerializer/JsvTypeSerializer inconsistently uses the AssumeUtc config setting #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig setting DateTime handling is inconsistent with respect to the AssumcUtc when using the JSConfig setting. If serializing to JSON - The JsonTypeSerializer will use the UTC specification type and convert Unspecified DateTime values to UTC in method "WriteWcfJsonDate" If serializing to CSV- The JsvTypeSerializer will not use the UTC specification type and does not convert Unspecified DateTime values to UTC in method "ToShortestXsdDateTimeString" Adding an internal extension method "UseConfigSpecifiedSetting" to match DateTime conversion between the two different serializers.
Member
|
Cheers 👍 thx for the PR + test! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTime handling is inconsistent with respect to the
AssumcUtcwhen using theJSConfigsetting.If serializing to JSON - The
JsonTypeSerializerwill use the UTC specification type and convertUnspecifiedDateTime values to UTC in methodWriteWcfJsonDateIf serializing to CSV- The
JsvTypeSerializerwill not use the UTC specification type and does not convertUnspecifiedDateTime values to UTC in methodToShortestXsdDateTimeStringAdding an internal extension method
UseConfigSpecifiedSettingto match DateTime conversion between the two different serializers.