Made password optional when calling UpdateUserAuth. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is null or not provided the existing password will not be overwritten.
mythz
added a commit
that referenced
this pull request
Aug 7, 2013
Made password optional when calling UpdateUserAuth.
Contributor
|
cool, thx. |
Contributor
Author
|
This was my first pull request ever :D Thanks for the awesome framework. |
Contributor
|
Well in that case, Congratz and welcome to GitHub! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating a UserAuth without having the raw password is not possible.
Made the password parameter optional in the
UpdateUserAuthmethod.I also believe that this was your original intention that this should be possible seeing the null checks happening on the password variable within
UpdateUserAuth. These are useless in the current implementation because an exception will be thrown on the assert inValidateNewUserand the code will never reach the null checks anyway.