This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Refactor #disableSet to #registerSet #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2449
💛 - Coveralls |
justinkchen
reviewed
Nov 2, 2018
felix2feng
reviewed
Nov 2, 2018
hydrazines
force-pushed
the
andy/register-set
branch
from
7b8e913 to
b04b80f
Compare
asoong
approved these changes
Nov 2, 2018
Contributor
asoong
left a comment
asoong
left a comment
There was a problem hiding this comment.
Conditional, we may want the ability to enable another token to address a disabled token in the case where users have funds locked up. Having the ability to register factories poses the same threat.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.