Skip to content
This repository was archived by the owner on Jan 18, 2023. It is now read-only.

Fix Chunk Size Assertion #380

Merged
controtie merged 3 commits into from
May 30, 2020
Merged

Fix Chunk Size Assertion #380

controtie merged 3 commits into from
May 30, 2020

Conversation

@controtie
Copy link
Contributor

@controtie controtie commented May 29, 2020

Fix Chunk Size Assertion

  • Replaces the chunk size assertion with bigNumber's less than/greater than methods
  • The previous assertion would convert to strings and '<' or '>' would do a string comparison

@controtie controtie merged commit 0094479 into master May 30, 2020
@controtie controtie deleted the dylan/chunk-size-assertion branch May 30, 2020 00:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@justinkchen justinkchen justinkchen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@controtie @justinkchen