Skip to content

feat(ui): TextField에 maxLength Error 처리 로직을 추가합니다. #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jungwoo3490 merged 2 commits into from
Dec 7, 2024
Merged

feat(ui): TextField에 maxLength Error 처리 로직을 추가합니다. #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0faaed2
feat(ui): add maxlength error handling logic in textfield component
jungwoo3490 Dec 7, 2024
676eef2
add changeset
jungwoo3490 Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brave-zebras-cross.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@setaday/ui": minor
---

Add maxlength error handling logic in TextField
14 changes: 11 additions & 3 deletions packages/ui/src/TextField/TextField.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { cva } from "class-variance-authority";

export const textFieldVariants = cva(
`rounded-[0.8rem] bg-gray-1 flex justify-between items-center px-[2rem] gap-[1rem]`,
"rounded-[0.8rem] mb-[0.4rem] bg-gray-1 flex justify-between items-center px-[2rem] gap-[1rem]",
{
variants: {
isError: {
Expand All @@ -10,8 +10,16 @@ export const textFieldVariants = cva(
inputSize: {
desktop: "w-[33.5rem] h-[5.7rem]",
desktop_lg: "w-[51rem] h-[6.1rem]",
mobile: "w-[33.5rem] h-[4.8rem]",
mobile: "w-[100%] h-[4.8rem]",
Copy link
Copy Markdown
Member

@Arooming Arooming Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 !! 안그래도 인풋 너비가 고정되어 있어서 추후에 수정해야될 것 같다고 생각했었는데 야무지게 고쳐줬네용 짱

},
},
},
}
);

export const textCountVariants = cva("", {
variants: {
isError: {
true: "text-red-100",
},
},
});
50 changes: 38 additions & 12 deletions packages/ui/src/TextField/TextField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,52 @@
import { cn } from "@setaday/util";
import type { InputHTMLAttributes } from "react";
import { textFieldVariants } from "./TextField.styles";
import { textCountVariants, textFieldVariants } from "./TextField.styles";

interface TextFieldProps extends InputHTMLAttributes<HTMLInputElement> {
isError?: boolean;
errorMessage?: string;
maxLength: number;
inputSize: "desktop" | "desktop_lg" | "mobile";
value: string;
}

const TextField = ({ isError = false, value, maxLength, inputSize, ...inputProps }: TextFieldProps) => {
const TextField = ({ isError = false, errorMessage, value, maxLength, inputSize, ...inputProps }: TextFieldProps) => {
return (
<div className={cn(textFieldVariants({ isError, inputSize }))}>
<input
{...inputProps}
value={value}
className="bg-gray-1 text-gray-6 font-body7_m_16 w-full focus:outline-none"
/>
<span className="text-gray-2 font-body6_m_12">
{value.length}/{maxLength}
</span>
</div>
<>
<div
className={cn(
textFieldVariants({
isError: isError || value.length > maxLength,
inputSize,
})
)}
>
<input
{...inputProps}
value={value}
className="bg-gray-1 text-gray-6 font-body7_m_16 w-full focus:outline-none"
/>
<span className="text-gray-2 font-body6_m_12">
<span
className={cn(
textCountVariants({
isError: isError || value.length > maxLength,
})
)}
>
{value.length}
</span>
/{maxLength}
</span>
</div>
<div className="h-[1.45rem]">
{value.length > maxLength || (isError && errorMessage) ? (
<span className="text-red-100 font-caption1_m_12">
{value.length > maxLength ? `${maxLength}자가 초과되었어요` : errorMessage}
</span>
) : null}
</div>
</>
);
};

Expand Down