Skip to content

Conversation

@Hanmac
Copy link
Collaborator

@Hanmac Hanmac commented Jun 1, 2022

This adds a TestCase for the String Constraint

Closes #32

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #33 (5794b02) into master (335c3a8) will increase coverage by 11.96%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master      #33       +/-   ##
=============================================
+ Coverage     63.24%   75.21%   +11.96%     
  Complexity       45       45               
=============================================
  Files             6        6               
  Lines           117      117               
=============================================
+ Hits             74       88       +14     
+ Misses           43       29       -14     
Impacted Files Coverage Δ
src/Validator/CronExpressionValidator.php 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335c3a8...5794b02. Read the comment docs.

@Hanmac
Copy link
Collaborator Author

Hanmac commented Jun 1, 2022

the static code errors are invalid i think

  • the setParameter function isn't internal as they said
  • the return type from the provider i don't get it to return the right type without making other tests fail

@loevgaard
Copy link
Member

Thank you for this 🎉

@loevgaard loevgaard merged commit bbc77f4 into Setono:master Jun 1, 2022
@loevgaard
Copy link
Member

This commit fixed them, but introduced a new one :D

d7f1516

@loevgaard
Copy link
Member

And then we're green: 95473cc

Thanks for your contribution :)

@Hanmac Hanmac deleted the validatorTestCase branch December 8, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestCase for Validator

2 participants