Skip to content

Conversation

@Hanmac
Copy link
Collaborator

@Hanmac Hanmac commented Jun 7, 2022

This adds more tests for the FormTypeGuesser
mostly to that it returns null for the other methods

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #35 (7d4d487) into master (a9ddf86) will increase coverage by 4.25%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
+ Coverage     95.21%   99.46%   +4.25%     
  Complexity       69       69              
============================================
  Files             8        8              
  Lines           188      188              
============================================
+ Hits            179      187       +8     
+ Misses            9        1       -8     
Impacted Files Coverage Δ
src/Form/TypeGuesser/CronExpressionTypeGuesser.php 100.00% <0.00%> (+44.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9ddf86...7d4d487. Read the comment docs.

@loevgaard
Copy link
Member

Rebase onto master

@Hanmac Hanmac force-pushed the moreFormGuesserTests branch from 4f6184e to 89aa6f7 Compare June 7, 2022 11:35
@Hanmac Hanmac force-pushed the moreFormGuesserTests branch from d2aecf0 to 7d4d487 Compare June 7, 2022 11:41
@loevgaard loevgaard merged commit c896bbb into Setono:master Jun 7, 2022
@loevgaard
Copy link
Member

Love your work, Hans. Thank you 🎉

@Hanmac Hanmac deleted the moreFormGuesserTests branch December 11, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants